Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pipeline to tasks. #8157

Merged
merged 27 commits into from
May 21, 2024
Merged

Rename pipeline to tasks. #8157

merged 27 commits into from
May 21, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented May 16, 2024 •
edited
Loading

Description

Renaming the pipeline key to tasks in turbo.json.

We went this key to better express what Turborepo does with the configuration that is provided in this key. We've seen with users that the term "pipeline" can be confusing for how turbo really executes the task graph.

In reality, the keys in the pipeline object are really the list of tasks registered to turbo - so let's call it that.

Non-goals

This PR does not include:

  • The examples in the repo
  • JS packages
  • eslint-plugin-turbo

These updates will be needed in subsequent PRs.

Testing Instructions

Hopefully CI will do its job here - but, of course, would appreciate a review of my changes to make sure I'm not missing anything my untrained eye may be missing.

CLOSES TURBO-3225

@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 21, 2024 2:49am
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 21, 2024 2:49am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 21, 2024 2:49am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 2:49am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 2:49am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 2:49am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 2:49am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 2:49am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 2:49am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 2:49am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@anthonyshew anthonyshew mentioned this pull request May 17, 2024
Merged
@turbo-orchestrator turbo-orchestrator bot added the pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo label May 17, 2024
@anthonyshew anthonyshew changed the title Rename \"pipeline\" to \"tasks\". Rename pipeline to tasks. May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

packages/next-swc/crates/next-core/src/next_server/resolve.rs:14:22: �[38;5;9merror[E0432]: unresolved imports `turbopack_binding::turbopack::core::resolve::plugin::ResolvePlugin`, `turbopack_binding::turbopack::core::resolve::plugin::ResolvePluginCondition`
packages/next-swc/crates/next-core/src/next_shared/resolve.rs:20:22: �[38;5;9merror[E0432]: unresolved imports `turbopack_binding::turbopack::core::resolve::plugin::ResolvePlugin`, `turbopack_binding::turbopack::core::resolve::plugin::ResolvePluginCondition`
packages/next-swc/crates/next-core/src/next_client/context.rs:160:9: �[38;5;9merror[E0560]: struct `ResolveOptionsContext` has no field named `plugins`
packages/next-swc/crates/next-core/src/next_server/resolve.rs:64:4: �[38;5;9merror[E0277]: the trait bound `fn(Vc<FileSystemPath>) -> Vc<{type error}> {condition_inline_function}: IntoTaskFn<_, _>` is not satisfied
error: could not compile `next-core` (lib) due to 4 previous errors

See job summary for details

@anthonyshew anthonyshew merged commit 6acb90e into turborepo_2 May 21, 2024
55 checks passed
@anthonyshew anthonyshew deleted the rename-pipeline-to-tasks branch May 21, 2024 03:09
@chris-olszewski chris-olszewski mentioned this pull request May 21, 2024
Merged
tknickman pushed a commit that referenced this pull request May 21, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
bade972 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski pushed a commit that referenced this pull request May 22, 2024
@anthonyshew @chris-olszewski
Rename pipeline to tasks. (#8157)
584b25e 
### Description

Renaming the `pipeline` key to `tasks` in turbo.json.

We went this key to better express what Turborepo does with the
configuration that is provided in this key. We've seen with users that
the term "pipeline" can be confusing for how `turbo` _really_ executes
the task graph.

In reality, the keys in the `pipeline` object are really the list of
_tasks_ registered to `turbo` - so let's call it that.

### Non-goals

This PR does not include update:
-  The examples in the repo
- JS packages
- `eslint-plugin-turbo`

These updates will be needed in subsequent PRs.

### Testing Instructions

Hopefully CI will do its job here - but, of course, would appreciate a
review of my changes to make sure I'm not missing anything my untrained
eye may be missing.

CLOSES TURBO-3225
chris-olszewski added a commit that referenced this pull request May 22, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
97ee648 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski pushed a commit that referenced this pull request May 28, 2024
@anthonyshew @chris-olszewski
Rename pipeline to tasks. (#8157)
fdfddfc 
### Description

Renaming the `pipeline` key to `tasks` in turbo.json.

We went this key to better express what Turborepo does with the
configuration that is provided in this key. We've seen with users that
the term "pipeline" can be confusing for how `turbo` _really_ executes
the task graph.

In reality, the keys in the `pipeline` object are really the list of
_tasks_ registered to `turbo` - so let's call it that.

### Non-goals

This PR does not include update:
-  The examples in the repo
- JS packages
- `eslint-plugin-turbo`

These updates will be needed in subsequent PRs.

### Testing Instructions

Hopefully CI will do its job here - but, of course, would appreciate a
review of my changes to make sure I'm not missing anything my untrained
eye may be missing.

CLOSES TURBO-3225
chris-olszewski added a commit that referenced this pull request May 28, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
f8043cd 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski pushed a commit that referenced this pull request May 29, 2024
@anthonyshew @chris-olszewski
Rename pipeline to tasks. (#8157)
b8e21df 
### Description

Renaming the `pipeline` key to `tasks` in turbo.json.

We went this key to better express what Turborepo does with the
configuration that is provided in this key. We've seen with users that
the term "pipeline" can be confusing for how `turbo` _really_ executes
the task graph.

In reality, the keys in the `pipeline` object are really the list of
_tasks_ registered to `turbo` - so let's call it that.

### Non-goals

This PR does not include update:
-  The examples in the repo
- JS packages
- `eslint-plugin-turbo`

These updates will be needed in subsequent PRs.

### Testing Instructions

Hopefully CI will do its job here - but, of course, would appreciate a
review of my changes to make sure I'm not missing anything my untrained
eye may be missing.

CLOSES TURBO-3225
chris-olszewski added a commit that referenced this pull request May 29, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
acbe0f5 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski pushed a commit that referenced this pull request May 31, 2024
@anthonyshew @chris-olszewski
Rename pipeline to tasks. (#8157)
f1f80b5 
### Description

Renaming the `pipeline` key to `tasks` in turbo.json.

We went this key to better express what Turborepo does with the
configuration that is provided in this key. We've seen with users that
the term "pipeline" can be confusing for how `turbo` _really_ executes
the task graph.

In reality, the keys in the `pipeline` object are really the list of
_tasks_ registered to `turbo` - so let's call it that.

### Non-goals

This PR does not include update:
-  The examples in the repo
- JS packages
- `eslint-plugin-turbo`

These updates will be needed in subsequent PRs.

### Testing Instructions

Hopefully CI will do its job here - but, of course, would appreciate a
review of my changes to make sure I'm not missing anything my untrained
eye may be missing.

CLOSES TURBO-3225
chris-olszewski added a commit that referenced this pull request May 31, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
9780940 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
chris-olszewski pushed a commit that referenced this pull request Jun 4, 2024
@anthonyshew @chris-olszewski
Rename pipeline to tasks. (#8157)
de85f97 
### Description

Renaming the `pipeline` key to `tasks` in turbo.json.

We went this key to better express what Turborepo does with the
configuration that is provided in this key. We've seen with users that
the term "pipeline" can be confusing for how `turbo` _really_ executes
the task graph.

In reality, the keys in the `pipeline` object are really the list of
_tasks_ registered to `turbo` - so let's call it that.

### Non-goals

This PR does not include update:
-  The examples in the repo
- JS packages
- `eslint-plugin-turbo`

These updates will be needed in subsequent PRs.

### Testing Instructions

Hopefully CI will do its job here - but, of course, would appreciate a
review of my changes to make sure I'm not missing anything my untrained
eye may be missing.

CLOSES TURBO-3225
chris-olszewski added a commit that referenced this pull request Jun 4, 2024
@chris-olszewski
chore: unbreak turborepo_2 (#8183)
7c944a9 
### Description

#8180 and #8157 ended up landing in a way where `globs.t` will fail due
to using a test fixture that uses the now removed `pipeline` field.

### Testing Instructions

CI
@0xmaayan 0xmaayan mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman was automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang was automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyshew @chris-olszewski